Fix _polyprep, PolynomialRatio, for Number args
#571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 16 16
Lines 3193 3193
=======================================
Hits 3110 3110
Misses 83 83 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Martin Holters <[email protected]>
Co-authored-by: Martin Holters <[email protected]>
martinholters
approved these changes
Oct 29, 2024
Co-authored-by: Martin Holters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses
reverse(x), which is a method error forNumberarguments. ThusPolynomialRatio(::Number, ::Number)doesn't work as currently documented.This commit also reduces runtime dispatch.edit: guess it doesn't because of all the inlining anyway2nd edit: it wasn't, but now the type instabilities have been removed by manually inlining
_polyprep